Conversation
erikburt
added
the
run-e2e-tests
|
✅ No conflicts with other open PRs targeting |
|
|
There was a problem hiding this comment.
Pull request overview
This PR bumps the run-e2e-tests.yml reusable workflow reference from commit 9874c1f4ab4a4c70433df6d8f862044ca18456df to b6b1b68e52b1ddf359ceefcd93c5760a4201f21d across 5 workflow files. The new commit corresponds to the fix/run-e2e-tests-quarantine branch in the smartcontractkit/.github repository (PR #1449), which adds quarantine support for flaky test handling.
Changes:
- Updated 7
run-e2e-tests.ymlworkflow references across 5 CI workflow files to the new SHA pin.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/integration-tests.yml |
Bumped 2 run-e2e-tests.yml references (core and CCIP e2e tests) |
.github/workflows/integration-in-memory-tests.yml |
Bumped 2 run-e2e-tests.yml references (PR and merge queue in-memory tests) |
.github/workflows/automation-nightly-tests.yml |
Bumped 1 run-e2e-tests.yml reference (nightly automation tests) |
.github/workflows/automation-load-tests.yml |
Bumped 1 run-e2e-tests.yml reference (automation load tests) |
.github/workflows/automation-benchmark-tests.yml |
Bumped 1 run-e2e-tests.yml reference (automation benchmark tests) |
Risk Assessment: MEDIUM — While the changes are mechanically simple (SHA pin bumps), they point to a feature branch (fix/run-e2e-tests-quarantine) rather than the main branch of the upstream repo. This modifies CI behavior for critical e2e test workflows including integration tests, CCIP tests, automation nightly/load/benchmark tests.
Targeted Review Areas:
- Confirm the upstream commit
b6b1b68e52b1ddf359ceefcd93c5760a4201f21don thefix/run-e2e-tests-quarantinebranch has been reviewed and is stable before merging. - Verify the quarantine feature doesn't silently suppress real test failures in production CI.
Reviewer Recommendations:
- Per CODEOWNERS,
@smartcontractkit/devex-cicdand@smartcontractkit/devex-toolingown.github/**(line 101). The automation-specific workflows are additionally owned by@smartcontractkit/dev-services(lines 105-108).
Bumps
run-e2e-tests.ymlreusable workflow references to:fix/run-e2e-tests-quarantine(smartcontractkit/.github#1449).Testing
This PR. Haven't seen a test failure that was saved by quarantine on this PR. There's at least no regressions in the happy-case.
DX-3227